[
https://issues.apache.org/jira/browse/HDDS-1499?focusedWorklogId=239333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239333
]
ASF GitHub Bot logged work on HDDS-1499:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/19 17:30
Start Date: 08/May/19 17:30
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #798: HDDS-1499.
OzoneManager Cache.
URL: https://github.com/apache/hadoop/pull/798#discussion_r282165925
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java
##########
@@ -31,22 +38,40 @@
*/
public class TypedTable<KEY, VALUE> implements Table<KEY, VALUE> {
- private Table<byte[], byte[]> rawTable;
+ private final Table<byte[], byte[]> rawTable;
+
+ private final CodecRegistry codecRegistry;
- private CodecRegistry codecRegistry;
+ private final Class<KEY> keyType;
- private Class<KEY> keyType;
+ private final Class<VALUE> valueType;
- private Class<VALUE> valueType;
+ private final TableCache<CacheKey<KEY>, CacheValue<VALUE>> cache;
public TypedTable(
Table<byte[], byte[]> rawTable,
CodecRegistry codecRegistry, Class<KEY> keyType,
Class<VALUE> valueType) {
+ this(rawTable, codecRegistry, keyType, valueType,
+ null);
+ }
+
+
+ public TypedTable(
+ Table<byte[], byte[]> rawTable,
+ CodecRegistry codecRegistry, Class<KEY> keyType,
+ Class<VALUE> valueType, TableCache.CACHETYPE cachetype) {
this.rawTable = rawTable;
this.codecRegistry = codecRegistry;
this.keyType = keyType;
this.valueType = valueType;
+ if (cachetype == TableCache.CACHETYPE.FULLCACHE) {
Review comment:
It is impossible for the user to tell you apriori if they want a full cache
or partial cache. When you start a cluster you always want a full cache. We
should get a cache size -- or get a percentage of memory from the OM cache size
and use that if needed. Or for time being rely on the RocksDB doing the right
thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 239333)
Time Spent: 1.5h (was: 1h 20m)
> OzoneManager Cache
> ------------------
>
> Key: HDDS-1499
> URL: https://issues.apache.org/jira/browse/HDDS-1499
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In this Jira, we shall implement a cache for Table.
> As with OM HA, we are planning to implement double buffer implementation to
> flush transaction in a batch, instead of using rocksdb put() for every
> operation. When this comes in to place we need cache in OzoneManager HA to
> handle/server the requests for validation/returning responses.
>
> This Jira will implement Cache as an integral part of the table. In this way
> users using this table does not need to handle like check cache/db. For this,
> we can update get API in the table to handle the cache.
>
> This Jira will implement:
> # Cache as a part of each Table.
> # Uses this cache in get().
> # Exposes api for cleanup, add entries to cache.
> Usage to add the entries in to cache will be done in further jira's.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
