[
https://issues.apache.org/jira/browse/HDDS-1499?focusedWorklogId=239580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239580
]
ASF GitHub Bot logged work on HDDS-1499:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/19 04:42
Start Date: 09/May/19 04:42
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #798:
HDDS-1499. OzoneManager Cache.
URL: https://github.com/apache/hadoop/pull/798#discussion_r282336434
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBStore.java
##########
@@ -44,17 +45,20 @@
*/
Table<byte[], byte[]> getTable(String name) throws IOException;
+
/**
* Gets an existing TableStore with implicit key/value conversion.
*
* @param name - Name of the TableStore to get
* @param keyType
* @param valueType
+ * @param cachetype - Type of cache need to be used for this table.
* @return - TableStore.
* @throws IOException on Failure
*/
<KEY, VALUE> Table<KEY, VALUE> getTable(String name,
- Class<KEY> keyType, Class<VALUE> valueType) throws IOException;
+ Class<KEY> keyType, Class<VALUE> valueType,
+ TableCache.CACHETYPE cachetype) throws IOException;
Review comment:
Added this because for a few tables like bucket and volume table plan is to
maintain full table information, for other tables we maintain a partial cache,
whereas for few tables we don't want to maintain cache at all. (This is a
common interface for all tables in Ozone SCM/OM. So, having this option will
help to know which kind of cache need to be used for the table.)
As these are frequently used for validation of almost every operation in OM.
So, this might improve validation like bucket/volume exists or not checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 239580)
Time Spent: 2.5h (was: 2h 20m)
> OzoneManager Cache
> ------------------
>
> Key: HDDS-1499
> URL: https://issues.apache.org/jira/browse/HDDS-1499
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> In this Jira, we shall implement a cache for Table.
> As with OM HA, we are planning to implement double buffer implementation to
> flush transaction in a batch, instead of using rocksdb put() for every
> operation. When this comes in to place we need cache in OzoneManager HA to
> handle/server the requests for validation/returning responses.
>
> This Jira will implement Cache as an integral part of the table. In this way
> users using this table does not need to handle like check cache/db. For this,
> we can update get API in the table to handle the cache.
>
> This Jira will implement:
> # Cache as a part of each Table.
> # Uses this cache in get().
> # Exposes api for cleanup, add entries to cache.
> Usage to add the entries in to cache will be done in further jira's.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
