[
https://issues.apache.org/jira/browse/HDFS-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841423#comment-16841423
]
He Xiaoqiao commented on HDFS-14303:
------------------------------------
thanks [~iamgd67] for your report, quick review
[^HDFS-14303-branch-2.009.patch] and some minor comments,
a. #testLogAppender should be not necessary.
b. #testScanDirectoryStructureWarn lack some annotation but with marks.
c. patch name following <jira-id>-<branch>-<no>.patch should be better. just
like name HDFS-14303-branch-2.7.001.patch
FYI.
> chek block directory logic not correct when there is only meta file, print no
> meaning warn log
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-14303
> URL: https://issues.apache.org/jira/browse/HDFS-14303
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode, hdfs
> Affects Versions: 2.7.3, 2.9.2, 2.8.5
> Environment: env free
> Reporter: qiang Liu
> Priority: Minor
> Labels: easy-fix
> Attachments: HDFS-14303-branch-2.005.patch,
> HDFS-14303-branch-2.009.patch, HDFS-14303-branch-2.010.patch,
> HDFS-14303-branch-2.7.001.patch, HDFS-14303-branch-2.7.004.patch,
> HDFS-14303-branch-2.7.006.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> chek block directory logic not correct when there is only meta file,print no
> meaning warn log, eg:
> WARN DirectoryScanner:? - Block: 1101939874 has to be upgraded to block
> ID-based layout. Actual block file path:
> /data14/hadoop/data/current/BP-1461038173-10.8.48.152-1481686842620/current/finalized/subdir174/subdir68,
> expected block file path:
> /data14/hadoop/data/current/BP-1461038173-10.8.48.152-1481686842620/current/finalized/subdir174/subdir68/subdir68
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
