[
https://issues.apache.org/jira/browse/HDFS-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847984#comment-16847984
]
Chen Liang commented on HDFS-12979:
-----------------------------------
Thanks for the review [~xkrogen]. Post v009 patch.
Actually I was initially tweaking period and txn id to avoid having the new
variable. But the issue is some tests are already making assumptions about
these values for their own purpose, so changing these values can mess up the
test. And for some of the tests I needed to set these values very carefully:
being too small, checkpoint may get triggered too early, failing some checks;
being too large, the small delta can not be accepted, also failing the test. In
the end, it turned out to be even more messy/confusing and less readable. Also,
this makes it complex to add new unit test on this in the future. My thought
here was to let this behave as if having a new configuration key, except the
configuration is not exposed, but only used by tests. There are cases of
introducing variables for tests, such as
{{FSNameSystem#alwaysUseDelegationTokensForTests}}.
All other comments are addressed.
> StandbyNode should upload FsImage to ObserverNode after checkpointing.
> ----------------------------------------------------------------------
>
> Key: HDFS-12979
> URL: https://issues.apache.org/jira/browse/HDFS-12979
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Konstantin Shvachko
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-12979.001.patch, HDFS-12979.002.patch,
> HDFS-12979.003.patch, HDFS-12979.004.patch, HDFS-12979.005.patch,
> HDFS-12979.006.patch, HDFS-12979.007.patch, HDFS-12979.008.patch
>
>
> ObserverNode does not create checkpoints. So it's fsimage file can get very
> old making bootstrap of ObserverNode too long. A StandbyNode should copy
> latest fsimage to ObserverNode(s) along with ANN.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
