[
https://issues.apache.org/jira/browse/HDDS-1597?focusedWorklogId=250293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250293
]
ASF GitHub Bot logged work on HDDS-1597:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/19 17:08
Start Date: 29/May/19 17:08
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #860:
HDDS-1597. Remove hdds-server-scm dependency from ozone-common
URL: https://github.com/apache/hadoop/pull/860#discussion_r288663482
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/ServerUtils.java
##########
@@ -203,4 +203,25 @@ public static void setOzoneMetaDirPath(OzoneConfiguration
conf,
conf.set(HddsConfigKeys.OZONE_METADATA_DIRS, path);
}
+ /**
+ * Returns with the service specific metadata directory.
+ * <p>
+ * If the directory is missing the method tries to create it.
+ *
+ * @param conf the ozone configuration object
+ * @param key The configuration key which specify the director.
Review comment:
Minor NIT: director -> directory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 250293)
Time Spent: 1h 50m (was: 1h 40m)
> Remove hdds-server-scm dependency from ozone-common
> ---------------------------------------------------
>
> Key: HDDS-1597
> URL: https://issues.apache.org/jira/browse/HDDS-1597
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Attachments: ozone-dependency.png
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> I noticed that the hadoop-ozone/common project depends on
> hadoop-hdds-server-scm project.
> The common projects are designed to be a shared artifacts between client and
> server side. Adding additional dependency to the common pom means that the
> dependency will be available for all the clients as well.
> (See the attached artifact about the current, desired structure).
> We definitely don't need scm server dependency on the client side.
> The code dependency is just one class (ScmUtils) and the shared code can be
> easily moved to the common.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
