[
https://issues.apache.org/jira/browse/HDDS-1597?focusedWorklogId=250885&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250885
]
ASF GitHub Bot logged work on HDDS-1597:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/19 10:31
Start Date: 30/May/19 10:31
Worklog Time Spent: 10m
Work Description: elek commented on issue #860: HDDS-1597. Remove
hdds-server-scm dependency from ozone-common
URL: https://github.com/apache/hadoop/pull/860#issuecomment-497284787
> I have a question, why we explicilty added commons-lang as dependency with
scope test here? Which we have not done before. Is this for a reason so that
down stream who depend on server-scm don't get this dependency. Because
previously without this patch, we don't have anywhere commons-lang defined in
our pom.xml. I think it is transitive dependency from one of the jars.
Very good question. I just realized that it can't be compiled and I added
the dependency without checking the reason ;-)
I tried to answer your question and analyzed the dependencies but it turned
out that it's not about the transitive dependencies:
I moved the TestKeymanagerImpl from ozone-manager project to the
integration-test project because it requires the the scm classes for testing.
Until now we collected all of these unit tests (which require multiple daemon
projects and starts real servers like the MiniOzoneCluster) in the
integration-test project, so I think it's the best place anyway (and it was
required because I removed the scm dependency of om).
And common-lang2 was a dependency of OM but not the integration-test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 250885)
Time Spent: 2h 10m (was: 2h)
> Remove hdds-server-scm dependency from ozone-common
> ---------------------------------------------------
>
> Key: HDDS-1597
> URL: https://issues.apache.org/jira/browse/HDDS-1597
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Attachments: ozone-dependency.png
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> I noticed that the hadoop-ozone/common project depends on
> hadoop-hdds-server-scm project.
> The common projects are designed to be a shared artifacts between client and
> server side. Adding additional dependency to the common pom means that the
> dependency will be available for all the clients as well.
> (See the attached artifact about the current, desired structure).
> We definitely don't need scm server dependency on the client side.
> The code dependency is just one class (ScmUtils) and the shared code can be
> easily moved to the common.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
