[
https://issues.apache.org/jira/browse/HDDS-1621?focusedWorklogId=254904&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254904
]
ASF GitHub Bot logged work on HDDS-1621:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/19 06:02
Start Date: 06/Jun/19 06:02
Worklog Time Spent: 10m
Work Description: supratimdeka commented on pull request #917: HDDS-1621.
writeData in ChunkUtils should not use AsynchronousFileChannel. Contributed by
Supratim Deka
URL: https://github.com/apache/hadoop/pull/917
https://issues.apache.org/jira/browse/HDDS-1621
2 changes:
1. invoking a force+close on the channel inside writeData if
dfs.container.chunk.write.sync is true. The force is triggered outside of the
file lock, to avoid unnecessary lock contention.
2. change AsynchronousFileChannel to FileChannel for writing the file. This
is the right thing to do because writeStateMachineData is already scheduling
the write chunk requests asynchronously on threads from
XceiverServerRatis.chunkExecutor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254904)
Time Spent: 10m
Remaining Estimate: 0h
> writeData in ChunkUtils should not use AsynchronousFileChannel
> --------------------------------------------------------------
>
> Key: HDDS-1621
> URL: https://issues.apache.org/jira/browse/HDDS-1621
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Shashikant Banerjee
> Assignee: Supratim Deka
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, chunks writes are not synced to disk by default. When
> flushStateMachineData gests invoked from Ratis, it should also ensure all the
> pending chunk writes should be flushed to disk.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
