[
https://issues.apache.org/jira/browse/HDDS-1621?focusedWorklogId=254940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254940
]
ASF GitHub Bot logged work on HDDS-1621:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/19 07:30
Start Date: 06/Jun/19 07:30
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #917: HDDS-1621.
writeData in ChunkUtils should not use AsynchronousFileChannel. Contributed by
Supratim Deka
URL: https://github.com/apache/hadoop/pull/917#issuecomment-499382213
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 34 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 551 | trunk passed |
| +1 | compile | 302 | trunk passed |
| +1 | checkstyle | 74 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 861 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 176 | trunk passed |
| 0 | spotbugs | 371 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 588 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 502 | the patch passed |
| +1 | compile | 298 | the patch passed |
| +1 | javac | 298 | the patch passed |
| +1 | checkstyle | 75 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 639 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 176 | the patch passed |
| +1 | findbugs | 626 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 58 | hadoop-hdds in the patch failed. |
| -1 | unit | 53 | hadoop-ozone in the patch failed. |
| 0 | asflicense | 20 | ASF License check generated no output? |
| | | 5215 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-917/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/917 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux bb90d43e0df1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 73954c1 |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-917/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-917/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-917/1/testReport/ |
| Max. process+thread count | 444 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/container-service U:
hadoop-hdds/container-service |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-917/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254940)
Time Spent: 20m (was: 10m)
> writeData in ChunkUtils should not use AsynchronousFileChannel
> --------------------------------------------------------------
>
> Key: HDDS-1621
> URL: https://issues.apache.org/jira/browse/HDDS-1621
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Shashikant Banerjee
> Assignee: Supratim Deka
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, chunks writes are not synced to disk by default. When
> flushStateMachineData gests invoked from Ratis, it should also ensure all the
> pending chunk writes should be flushed to disk.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
