[
https://issues.apache.org/jira/browse/HDDS-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862190#comment-16862190
]
Elek, Marton commented on HDDS-1667:
------------------------------------
Thanks the update [~eyang]. Overall it looks good to me. I would like to test
it, but it seems to have a merge problem.
1. Can you please rebase it (or please upload it as a PR, that could be tested
even if conflicted with the current trunk)
2. I didn't test it, but based on the source code you changed the default from
'apache/hadoop:${project.version}' to '${user.name}/ozone:${project.version}'.
Which means that the dist/release build will create invalid kubernetes
manifests. I would prefer to keep the current behaviour which means that by
default the apache image name is used.
> Docker compose file may referring to incorrect docker image name
> ----------------------------------------------------------------
>
> Key: HDDS-1667
> URL: https://issues.apache.org/jira/browse/HDDS-1667
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Trivial
> Fix For: 0.4.1
>
> Attachments: HDDS-1667.001.patch, HDDS-1667.002.patch
>
>
> In fault injection test, the docker compose file is templated using:
> ${user.name}/ozone:${project.version}
> If user pass in parameter -Ddocker.image to cause docker build to generate a
> different name. This can cause fault injection test to fail/stuck because it
> could not find the required docker image. The fix is simply use docker.image
> token to filter docker compose file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
