[
https://issues.apache.org/jira/browse/HDDS-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862269#comment-16862269
]
Eric Yang commented on HDDS-1667:
---------------------------------
{quote}2. I didn't test it, but based on the source code you changed the
default from 'apache/hadoop:${project.version}' to
'${user.name}/ozone:${project.version}'. Which means that the dist/release
build will create invalid kubernetes manifests. I would prefer to keep the
current behaviour which means that by default the apache image name is
used.{quote}
In the current hadoop/hadoop-ozone/dist/pom.xml, docker-build profile defines
properties to ${user.name}/ozone:${project.version}, the current trunk
generates kubernetes yaml files that looks like:
{code}
grep -R image *
datanode-ds.yaml: image: "eyang/ozone:0.5.0-SNAPSHOT"
freon/freon.yaml: image: "eyang/ozone:0.5.0-SNAPSHOT"
om-ss.yaml: image: elek/ozone
om-ss.yaml: image: "eyang/ozone:0.5.0-SNAPSHOT"
s3g-ss.yaml: image: "eyang/ozone:0.5.0-SNAPSHOT"
scm-ss.yaml: image: "eyang/ozone:0.5.0-SNAPSHOT"
scm-ss.yaml: image: elek/ozone
{code}
Are you saying that we should remove this snip of code from docker-build?
{code}
<properties>
<docker.image>${user.name}/ozone:${project.version}</docker.image>
</properties>
{code}
> Docker compose file may referring to incorrect docker image name
> ----------------------------------------------------------------
>
> Key: HDDS-1667
> URL: https://issues.apache.org/jira/browse/HDDS-1667
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Trivial
> Fix For: 0.4.1
>
> Attachments: HDDS-1667.001.patch, HDDS-1667.002.patch
>
>
> In fault injection test, the docker compose file is templated using:
> ${user.name}/ozone:${project.version}
> If user pass in parameter -Ddocker.image to cause docker build to generate a
> different name. This can cause fault injection test to fail/stuck because it
> could not find the required docker image. The fix is simply use docker.image
> token to filter docker compose file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
