[
https://issues.apache.org/jira/browse/HDFS-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862953#comment-16862953
]
Adam Antal commented on HDFS-14203:
-----------------------------------
The findbug entry is relevant - fixed it.
Also the checkstyles are taken care of.
What is strange is the errors: all tests passes on my local (sometimes failing
with timeout) including TestOfflineImageViewer.
In the new tests if I change the expected string that can be seen in the
jenkins output I get the following error:
{noformat}
org.junit.ComparisonFailure:
Expected :/path/sym,0,2000-01-01 00:00,2000-01-01
00:00,0,0,0,0,0,-rwx-wx-w-,user_1,group_1
Actual :/path/sym,0,2000-01-01 01:00,2000-01-01
01:00,0,0,0,0,0,-rwx-wx-w-,user_1,group_1
{noformat}
It looks like the following unix timestamp:
{code:java}
private static final long SAMPLE_TIMESTAMP = 946684800000L;
{code}
is producing different results in the two machines. Searched and checked among
the UNIX-timestamp converters online, and I concluded that something is wrong
with my computer locally. Changed the strings and the other items in
[^HDFS-14203.002.patch].
> Refactor OIV Delimited output entry building mechanism
> ------------------------------------------------------
>
> Key: HDFS-14203
> URL: https://issues.apache.org/jira/browse/HDFS-14203
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: tools
> Affects Versions: 3.2.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Minor
> Attachments: HDFS-14203.001.patch, HDFS-14203.002.patch
>
>
> As of some recent improvements in the OIV tool, fields are getting added. For
> sustainability I propose to introduce a Builder pattern in
> {{PBImageDelimitedTextWriter}}, which is also prettier than constructing
> entries like this:
> {code:java}
> case SYMLINK:
> INodeSymlink s = inode.getSymlink();
> p = getPermission(s.getPermission());
> append(buffer, 0); // Replication
> append(buffer, formatDate(s.getModificationTime()));
> append(buffer, formatDate(s.getAccessTime()));
> append(buffer, 0); // Block size.
> append(buffer, 0); // Num blocks.
> append(buffer, 0); // Num bytes.
> append(buffer, 0); // NS_QUOTA
> append(buffer, 0); // DS_QUOTA
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
