[
https://issues.apache.org/jira/browse/HDFS-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864686#comment-16864686
]
Hudson commented on HDFS-14203:
-------------------------------
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16752 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/16752/])
HDFS-14203. Refactor OIV Delimited output entry building mechanism. (weichiu:
rev 8370a0ae1681f2836fa0c1c63e334a3fdafafd7b)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageDelimitedTextWriter.java
> Refactor OIV Delimited output entry building mechanism
> ------------------------------------------------------
>
> Key: HDFS-14203
> URL: https://issues.apache.org/jira/browse/HDFS-14203
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: tools
> Affects Versions: 3.2.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Minor
> Attachments: HDFS-14203.001.patch, HDFS-14203.002.patch,
> HDFS-14203.003.patch
>
>
> As of some recent improvements in the OIV tool, fields are getting added. For
> sustainability I propose to introduce a Builder pattern in
> {{PBImageDelimitedTextWriter}}, which is also prettier than constructing
> entries like this:
> {code:java}
> case SYMLINK:
> INodeSymlink s = inode.getSymlink();
> p = getPermission(s.getPermission());
> append(buffer, 0); // Replication
> append(buffer, formatDate(s.getModificationTime()));
> append(buffer, formatDate(s.getAccessTime()));
> append(buffer, 0); // Block size.
> append(buffer, 0); // Num blocks.
> append(buffer, 0); // Num bytes.
> append(buffer, 0); // NS_QUOTA
> append(buffer, 0); // DS_QUOTA
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
