[
https://issues.apache.org/jira/browse/HDDS-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866566#comment-16866566
]
Elek, Marton commented on HDDS-1667:
------------------------------------
Thanks [~eyang] the updated. To be honest it seems to be a new patch as it
includes fundamental changes compared to the earlier version which was reviewed.
Unfortunately it seems to be broken compared to the previous version.
(1) It includes both ozone.docker.image and docker.image properties which is
very confusing. (hadoop-ozone/dist/pom.xmlL31). I am fined to rename
docker.image to ozone.docker.image but please rename it everywhere (and if you
renamed it in dist, you should updated the k8s files)
(2) apache/hadoop-runner image is replaced with${ozone.docker.image}. I don't
know why. It seems to be independent from the description of this jira:
{quote}The fix is simply use docker.image token to filter docker compose file.
{quote}
And IMHO it's not a good way to go forward. (I may be wrong, but it's a big
change and should be discussed first in a separated thread)
(3) ozonesecure can't be started any more from the compose/ozonesecure folder
due to the usage of HADOOP_IMAGE. I don't see any reason to use HADOOP_IMAGE
(are you planning to use any 3rd party hadoop image instead of apache/hadoop?).
But if you would like to introduce it, the default value should be added to the
.env file (and because the limitation of docker-compose it should be added to
the /compose/.env IMHO)
Again this seems to be an independent change and the description of the Jira
doesn't explain why is it necessary:
{quote}The fix is simply use docker.image token to filter docker compose file.
{quote}
(4) I think you didn't execute all the smoketests before posting the patch.
Would you be so kind to post this patch as a github pull request to get full
acceptance test results?
> Docker compose file may referring to incorrect docker image name
> ----------------------------------------------------------------
>
> Key: HDDS-1667
> URL: https://issues.apache.org/jira/browse/HDDS-1667
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Trivial
> Fix For: 0.4.1
>
> Attachments: HDDS-1667.001.patch, HDDS-1667.002.patch,
> HDDS-1667.003.patch, HDDS-1667.004.patch, HDDS-1667.005.patch
>
>
> In fault injection test, the docker compose file is templated using:
> ${user.name}/ozone:${project.version}
> If user pass in parameter -Ddocker.image to cause docker build to generate a
> different name. This can cause fault injection test to fail/stuck because it
> could not find the required docker image. The fix is simply use docker.image
> token to filter docker compose file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
