[ 
https://issues.apache.org/jira/browse/HDDS-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866569#comment-16866569
 ] 

Elek, Marton commented on HDDS-1567:
------------------------------------

Thank you very much to explain it [~eyang]. Finally it's more clear for me and 
I can imagine what is the goal.

I think it's a good idea, but I propose to achieve the same goal with a 
slightly different implementation.
{quote}Are you calling this tag?
{quote}
No, I am calling the value of the <tag> elements as tags: (for example this 
line: 
[https://github.com/apache/hadoop/blob/trunk/hadoop-hdds/common/src/main/resources/ozone-default.xml#L43)]

But, back to my proposal. I propose the following implementation:
 # Improve OzoneConfiguration to load values directly from environment 
variables based on naming convention. For example in case of ozone.om.address 
if OZONE_OM_ADDRESS is set it should be considered with higher priority.
 # With this modification envtoconf.py will be optional for ozone-site.xml (not 
for log4j/spark settings)
 # We can introduce smart default values (eg. 
ozone.om.http-address=${ozone.om.address}:9874. With this approach we don't 
need to set the same hostname multiple times, as you suggested.
 # As a result we can support the use case what you described but *it can work 
exactly the same way* with both the on-prem and containerized installs.

 

> Define a set of environment variables to configure Ozone docker image
> ---------------------------------------------------------------------
>
>                 Key: HDDS-1567
>                 URL: https://issues.apache.org/jira/browse/HDDS-1567
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Eric Yang
>            Priority: Major
>
> For developer that tries to setup docker image by end for testing purpose, it 
> would be nice to predefine a set of environment variables that can be passed 
> to Ozone docker image to configure the minimum set of configuration to start 
> Ozone containers.  There is a python script that converts environment 
> variables to config, but documentation does not show what setting can be 
> passed to configure the system.  This task would be a good starting point to 
> document the available configuration knobs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to