[
https://issues.apache.org/jira/browse/HDDS-1258?focusedWorklogId=264528&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264528
]
ASF GitHub Bot logged work on HDDS-1258:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/19 10:59
Start Date: 21/Jun/19 10:59
Worklog Time Spent: 10m
Work Description: sodonnel commented on pull request #1001: HDDS-1258 -
Fix error propagation for SCM protocol
URL: https://github.com/apache/hadoop/pull/1001
Following on from HDDS-1674, which changed the SCMBlockLocationProtocol to
use a single wrapper message for all child messages, this change ensures that
any known SCMException's are caught and the correct code and message written to
the wrapper.
Note that the client does not see the benifit of the new error handling, as
the generally the client calls CLIENT -> OM -> SCM, and even with this change
the OM cannot translate the SCM response codes into a more meaningful error
message for the client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 264528)
Time Spent: 10m
Remaining Estimate: 0h
> Fix error propagation for SCM protocol
> --------------------------------------
>
> Key: HDDS-1258
> URL: https://issues.apache.org/jira/browse/HDDS-1258
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Stephen O'Donnell
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> HDDS-1068 fixed the error propagation between the OM client and OM server.
> By default the Server.java transforms all the IOExceptions to one string
> (message + stack trace) and this is returned to the client.
> But for business exception (eg. volume not found, chill mode is active, etc.)
> this is not what we need.
> In the OM side we fixed this behaviour. In the ServerSideTranslator classes
> we catch (server) the business (OMException) exceptions and serialize them to
> the response object.
> The exception (and the status code) is stored in message/status field of the
> OMResponse (hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto)
> Here I propose to do the same for the ScmBlockLocationProtocol.proto.
> Unfortunately there is no common parent object (like OMRequest) in this
> protocol, but we can easily add one as only the Serverside/Clientside
> translator should be changed for that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
