[
https://issues.apache.org/jira/browse/HDDS-1258?focusedWorklogId=266596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-266596
]
ASF GitHub Bot logged work on HDDS-1258:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/19 12:15
Start Date: 25/Jun/19 12:15
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1001: HDDS-1258 - Fix
error propagation for SCM protocol
URL: https://github.com/apache/hadoop/pull/1001#issuecomment-505418023
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 32 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 523 | trunk passed |
| +1 | compile | 269 | trunk passed |
| +1 | checkstyle | 68 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 841 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 149 | trunk passed |
| 0 | spotbugs | 335 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 542 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 485 | the patch passed |
| +1 | compile | 266 | the patch passed |
| +1 | cc | 266 | the patch passed |
| +1 | javac | 266 | the patch passed |
| +1 | checkstyle | 68 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 658 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 156 | the patch passed |
| +1 | findbugs | 549 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 155 | hadoop-hdds in the patch failed. |
| -1 | unit | 721 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 39 | The patch does not generate ASF License warnings. |
| | | 5672 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests |
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerCommandHandler
|
| | hadoop.ozone.web.client.TestKeysRatis |
| | hadoop.ozone.web.client.TestKeys |
| | hadoop.ozone.client.rpc.TestReadRetries |
| | hadoop.ozone.om.TestScmSafeMode |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1001/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1001 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle cc |
| uname | Linux 2400e99c3cf4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 48d7f00 |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1001/3/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1001/3/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1001/3/testReport/ |
| Max. process+thread count | 2350 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common U: hadoop-hdds/common |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1001/3/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 266596)
Time Spent: 1h 50m (was: 1h 40m)
> Fix error propagation for SCM protocol
> --------------------------------------
>
> Key: HDDS-1258
> URL: https://issues.apache.org/jira/browse/HDDS-1258
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Stephen O'Donnell
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> HDDS-1068 fixed the error propagation between the OM client and OM server.
> By default the Server.java transforms all the IOExceptions to one string
> (message + stack trace) and this is returned to the client.
> But for business exception (eg. volume not found, chill mode is active, etc.)
> this is not what we need.
> In the OM side we fixed this behaviour. In the ServerSideTranslator classes
> we catch (server) the business (OMException) exceptions and serialize them to
> the response object.
> The exception (and the status code) is stored in message/status field of the
> OMResponse (hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto)
> Here I propose to do the same for the ScmBlockLocationProtocol.proto.
> Unfortunately there is no common parent object (like OMRequest) in this
> protocol, but we can easily add one as only the Serverside/Clientside
> translator should be changed for that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
