[
https://issues.apache.org/jira/browse/HDDS-1638?focusedWorklogId=264814&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264814
]
ASF GitHub Bot logged work on HDDS-1638:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/19 17:20
Start Date: 21/Jun/19 17:20
Worklog Time Spent: 10m
Work Description: hanishakoneru commented on pull request #956:
HDDS-1638. Implement Key Write Requests to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/956#discussion_r296066456
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##########
@@ -0,0 +1,250 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.key;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.apache.hadoop.util.Time;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.hdds.scm.container.common.helpers.ExcludeList;
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.AuditLogger;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo;
+import org.apache.hadoop.ozone.om.request.OMClientRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.key.OMAllocateBlockResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .AllocateBlockRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .AllocateBlockResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .KeyArgs;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .OMResponse;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+
+import static org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes
+ .KEY_NOT_FOUND;
+
+/**
+ * Handles allocate block request.
+ */
+public class OMAllocateBlockRequest extends OMClientRequest
+ implements OMKeyRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(OMAllocateBlockRequest.class);
+
+ public OMAllocateBlockRequest(OMRequest omRequest) {
+ super(omRequest);
+ }
+
+ @Override
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+
+ AllocateBlockRequest allocateBlockRequest =
+ getOmRequest().getAllocateBlockRequest();
+
+ Preconditions.checkNotNull(allocateBlockRequest);
+
+ KeyArgs keyArgs = allocateBlockRequest.getKeyArgs();
+
+ ExcludeList excludeList = new ExcludeList();
+ if (allocateBlockRequest.hasExcludeList()) {
+ excludeList =
+ ExcludeList.getFromProtoBuf(allocateBlockRequest.getExcludeList());
+ }
+
+ // TODO: Here we are allocating block with out any check for key exist in
+ // open table or not and also with out any authorization checks.
+ // Assumption here is that allocateBlocks with out openKey will be less.
+ // There is a chance some one can misuse this api to flood allocateBlock
+ // calls. But currently allocateBlock is internally called from
+ // BlockOutputStreamEntryPool, so we are fine for now. But if one some
+ // one uses direct omclient we might be in trouble.
+
+
+ // To allocate atleast one block passing requested size and scmBlockSize
+ // as same value. When allocating block requested size is same as
+ // scmBlockSize.
+ List<OmKeyLocationInfo> omKeyLocationInfoList =
+ allocateBlock(ozoneManager.getScmClient(),
+ ozoneManager.getBlockTokenSecretManager(), keyArgs.getType(),
+ keyArgs.getFactor(), excludeList, ozoneManager.getScmBlockSize(),
+ ozoneManager.getScmBlockSize(),
+ ozoneManager.getPreallocateBlocksMax(),
+ ozoneManager.isGrpcBlockTokenEnabled(),
ozoneManager.getOMNodeId());
+
+ // Set modification time
+ KeyArgs.Builder newKeyArgs = keyArgs.toBuilder()
+ .setModificationTime(Time.now());
+
+ AllocateBlockRequest.Builder newAllocatedBlockRequest =
+ AllocateBlockRequest.newBuilder()
+ .setClientID(allocateBlockRequest.getClientID())
+ .setKeyArgs(newKeyArgs);
+
+
+
+ if (allocateBlockRequest.hasExcludeList()) {
+ newAllocatedBlockRequest.setExcludeList(
+ allocateBlockRequest.getExcludeList());
+ }
+
+ // Add allocated block info.
+ newAllocatedBlockRequest.setKeyLocation(
+ omKeyLocationInfoList.get(0).getProtobuf());
+
+ return getOmRequest().toBuilder().setUserInfo(getUserInfo())
+ .setAllocateBlockRequest(newAllocatedBlockRequest).build();
+
+ }
+
+ @Override
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ long transactionLogIndex) {
+
+ OzoneManagerProtocolProtos.AllocateBlockRequest allocateBlockRequest =
+ getOmRequest().getAllocateBlockRequest();
+ Preconditions.checkNotNull(allocateBlockRequest);
+
+ OzoneManagerProtocolProtos.KeyArgs keyArgs =
+ allocateBlockRequest.getKeyArgs();
+
+ OzoneManagerProtocolProtos.KeyLocation blockLocation =
+ allocateBlockRequest.getKeyLocation();
+ Preconditions.checkNotNull(blockLocation);
+
+ String volumeName = keyArgs.getVolumeName();
+ String bucketName = keyArgs.getBucketName();
+ String keyName = keyArgs.getKeyName();
+ long clientID = allocateBlockRequest.getClientID();
+
+ OMMetrics omMetrics = ozoneManager.getMetrics();
+ omMetrics.incNumAddAllocateBlockCalls();
+
+ AuditLogger auditLogger = ozoneManager.getAuditLogger();
+
+ Map<String, String> auditMap = buildKeyArgsAuditMap(keyArgs);
+ auditMap.put(OzoneConsts.CLIENT_ID, String.valueOf(clientID));
+
+ OMResponse.Builder omResponse = OMResponse.newBuilder().setCmdType(
+ OzoneManagerProtocolProtos.Type.AllocateBlock).setStatus(
+ OzoneManagerProtocolProtos.Status.OK).setSuccess(true);
+
+ try {
+ // check Acl
+ if (ozoneManager.getAclsEnabled()) {
+ checkAcls(ozoneManager, OzoneObj.ResourceType.KEY,
+ OzoneObj.StoreType.OZONE, IAccessAuthorizer.ACLType.WRITE,
+ volumeName, bucketName, keyName);
+ }
+ } catch (IOException ex) {
+ LOG.error("AllocateBlock failed for Key: {} in volume/bucket:{}/{}",
+ keyName, bucketName, volumeName, ex);
+ omMetrics.incNumBlockAllocateCallFails();
+ auditLog(auditLogger, buildAuditMessage(OMAction.ALLOCATE_BLOCK,
auditMap,
+ ex, getOmRequest().getUserInfo()));
+ return new OMAllocateBlockResponse(null, -1L,
+ createErrorOMResponse(omResponse, ex));
+ }
+
+ OMMetadataManager omMetadataManager = ozoneManager.getMetadataManager();
+ try {
+ validateBucket(omMetadataManager, volumeName,
+ bucketName);
+ } catch (IOException ex) {
+ LOG.error("AllocateBlock failed for Key: {} in volume/bucket:{}/{}",
+ keyName, bucketName, volumeName, ex);
+ omMetrics.incNumBlockAllocateCallFails();
+ auditLog(auditLogger, buildAuditMessage(OMAction.ALLOCATE_BLOCK,
auditMap,
+ ex, getOmRequest().getUserInfo()));
+ return new OMAllocateBlockResponse(null, -1L,
+ createErrorOMResponse(omResponse, ex));
+ }
+
+ String openKey = omMetadataManager.getOpenKey(
+ volumeName, bucketName, keyName, clientID);
+
+ IOException exception = null;
+ OmKeyInfo omKeyInfo = null;
+
+ // Here we don't acquire bucket/volume lock because for a single client
+ // allocateBlock is called in serial fashion.
+ try {
+ omKeyInfo = omMetadataManager.getOpenKeyTable().get(openKey);
+ if (omKeyInfo == null) {
+ throw new OMException("Open Key not found", KEY_NOT_FOUND);
+ }
+
+ // Append new block
+ omKeyInfo.appendNewBlocks(Collections.singletonList(
+ OmKeyLocationInfo.getFromProtobuf(blockLocation)), false);
+
+ // Set modification time.
+ omKeyInfo.setModificationTime(keyArgs.getModificationTime());
+
+ // Add to cache.
+ omMetadataManager.getOpenKeyTable().addCacheEntry(
+ new CacheKey<>(openKey), new CacheValue<>(Optional.of(omKeyInfo),
+ transactionLogIndex));
+
+ } catch (IOException ex) {
+ exception = ex;
+ }
+
+ // Performing audit logging outside of the lock.
Review comment:
We don't acquire any lock in this class. Comment is misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 264814)
Time Spent: 2h 20m (was: 2h 10m)
> Implement Key Write Requests to use Cache and DoubleBuffer
> ----------------------------------------------------------
>
> Key: HDDS-1638
> URL: https://issues.apache.org/jira/browse/HDDS-1638
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Implement Key write requests to use OM Cache, double buffer.
> In this Jira will add the changes to implement key operations, and HA/Non-HA
> will have a different code path, but once all requests are implemented will
> have a single code path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
