[
https://issues.apache.org/jira/browse/HDDS-1638?focusedWorklogId=264819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264819
]
ASF GitHub Bot logged work on HDDS-1638:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/19 17:20
Start Date: 21/Jun/19 17:20
Worklog Time Spent: 10m
Work Description: hanishakoneru commented on pull request #956:
HDDS-1638. Implement Key Write Requests to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/956#discussion_r296312475
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
##########
@@ -0,0 +1,375 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.key;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import org.apache.hadoop.fs.FileEncryptionInfo;
+import org.apache.hadoop.hdds.protocol.proto.HddsProtos;
+import org.apache.hadoop.hdds.scm.container.common.helpers.ExcludeList;
+import org.apache.hadoop.ozone.audit.AuditLogger;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.helpers.OmBucketInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfoGroup;
+import org.apache.hadoop.ozone.om.request.OMClientRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.key.OMKeyCreateResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .CreateKeyResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .CreateKeyRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .KeyArgs;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .OMResponse;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.util.Time;
+import org.apache.hadoop.utils.UniqueId;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+/**
+ * Handles CreateKey request.
+ */
+
+public class OMKeyCreateRequest extends OMClientRequest
+ implements OMKeyRequest {
+ private static final Logger LOG =
+ LoggerFactory.getLogger(OMKeyCreateRequest.class);
+
+ public OMKeyCreateRequest(OMRequest omRequest) {
+ super(omRequest);
+ }
+
+ @Override
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+ CreateKeyRequest createKeyRequest = getOmRequest().getCreateKeyRequest();
+ Preconditions.checkNotNull(createKeyRequest);
+
+ KeyArgs keyArgs = createKeyRequest.getKeyArgs();
+
+ // We cannot allocate block for multipart upload part when
+ // createMultipartKey is called, as we will not know type and factor with
+ // which initiateMultipartUpload has started for this key. When
+ // allocateBlock call happen's we shall know type and factor, as we set
+ // the type and factor read from multipart table, and set the KeyInfo in
+ // validateAndUpdateCache and return to the client. TODO: See if we can fix
+ // this.
+
+ CreateKeyRequest.Builder newCreateKeyRequest = null;
+ KeyArgs.Builder newKeyArgs = null;
+ if (!keyArgs.getIsMultipartKey()) {
+
+ long scmBlockSize = ozoneManager.getScmBlockSize();
+
+ // NOTE size of a key is not a hard limit on anything, it is a value that
+ // client should expect, in terms of current size of key. If client sets
+ // a value, then this value is used, otherwise, we allocate a single
+ // block which is the current size, if read by the client.
+ final long requestedSize = keyArgs.getDataSize() > 0 ?
+ keyArgs.getDataSize() : scmBlockSize;
+
+ boolean useRatis = ozoneManager.isUseRatis();
+
+ HddsProtos.ReplicationFactor factor = keyArgs.getFactor();
+ if (factor == null) {
+ factor = useRatis ? HddsProtos.ReplicationFactor.THREE :
+ HddsProtos.ReplicationFactor.ONE;
+ }
+
+ HddsProtos.ReplicationType type = keyArgs.getType();
+ if (type == null) {
+ type = useRatis ? HddsProtos.ReplicationType.RATIS :
+ HddsProtos.ReplicationType.STAND_ALONE;
+ }
+
+ // TODO: Here we are allocating block with out any check for
+ // bucket/key/volume or not and also with out any authorization checks.
+ // As for a client for the first time this can be executed on any OM,
+ // till leader is identified.
+
+ List< OmKeyLocationInfo > omKeyLocationInfoList =
+ allocateBlock(ozoneManager.getScmClient(),
+ ozoneManager.getBlockTokenSecretManager(), type, factor,
+ new ExcludeList(), requestedSize, scmBlockSize,
+ ozoneManager.getPreallocateBlocksMax(),
+ ozoneManager.isGrpcBlockTokenEnabled(),
+ ozoneManager.getOMNodeId());
+
+ newKeyArgs = keyArgs.toBuilder().setModificationTime(Time.now())
+ .setType(type).setFactor(factor)
+ .setDataSize(requestedSize);
+
+ newKeyArgs.addAllKeyLocations(omKeyLocationInfoList.stream()
+ .map(OmKeyLocationInfo::getProtobuf).collect(Collectors.toList()));
+ } else {
+ newKeyArgs = keyArgs.toBuilder().setModificationTime(Time.now());
+ }
+
+ newCreateKeyRequest =
+ createKeyRequest.toBuilder().setKeyArgs(newKeyArgs)
+ .setID(UniqueId.next());
+
+ return getOmRequest().toBuilder()
+ .setCreateKeyRequest(newCreateKeyRequest).setUserInfo(getUserInfo())
+ .build();
+ }
+
+ @Override
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ long transactionLogIndex) {
+ CreateKeyRequest createKeyRequest = getOmRequest().getCreateKeyRequest();
+ Preconditions.checkNotNull(createKeyRequest);
+
+
+ KeyArgs keyArgs = createKeyRequest.getKeyArgs();
+
+
+ String volumeName = keyArgs.getVolumeName();
+ String bucketName = keyArgs.getBucketName();
+ String keyName = keyArgs.getKeyName();
+
+ OMMetrics omMetrics = ozoneManager.getMetrics();
+ omMetrics.incNumKeyAllocates();
+
+ AuditLogger auditLogger = ozoneManager.getAuditLogger();
+
+ Map<String, String> auditMap = buildKeyArgsAuditMap(keyArgs);
+
+ OMResponse.Builder omResponse = OMResponse.newBuilder().setCmdType(
+ OzoneManagerProtocolProtos.Type.CreateKey).setStatus(
+ OzoneManagerProtocolProtos.Status.OK).setSuccess(true);
+
+ try {
+ // check Acl
+ if (ozoneManager.getAclsEnabled()) {
+ checkAcls(ozoneManager, OzoneObj.ResourceType.KEY,
+ OzoneObj.StoreType.OZONE, IAccessAuthorizer.ACLType.WRITE,
+ volumeName, bucketName, keyName);
+ }
+ } catch (IOException ex) {
+ LOG.error("Open failed for Key: {} in volume/bucket:{}/{}",
+ keyName, bucketName, volumeName, ex);
+ omMetrics.incNumKeyAllocateFails();
+ auditLog(auditLogger, buildAuditMessage(OMAction.ALLOCATE_KEY, auditMap,
+ ex, getOmRequest().getUserInfo()));
+ return new OMKeyCreateResponse(null, -1L,
+ createErrorOMResponse(omResponse, ex));
+ }
+
+ OMMetadataManager omMetadataManager = ozoneManager.getMetadataManager();
+ String dbOpenKeyName = omMetadataManager.getOpenKey(volumeName,
+ bucketName, keyName, createKeyRequest.getID());
+ String dbKeyName = omMetadataManager.getOzoneKey(volumeName, bucketName,
+ keyName);
+ String dbBucketKey = omMetadataManager.getBucketKey(volumeName,
bucketName);
+
+ OmKeyInfo omKeyInfo = null;
+ final List< OmKeyLocationInfo > locations = new ArrayList<>();
+ FileEncryptionInfo encryptionInfo = null;
+ long openVersion = 0L;
+ IOException exception = null;
+ omMetadataManager.getLock().acquireBucketLock(volumeName, bucketName);
+ try {
+ validateBucket(omMetadataManager, volumeName, bucketName);
+ //TODO: We can optimize this get here, if getKmsProvider is null, then
+ // bucket encryptionInfo will be not set. If this assumption holds
+ // true, we can avoid get from bucket table.
+ OmBucketInfo bucketInfo =
+ omMetadataManager.getBucketTable().get(dbBucketKey);
+ encryptionInfo = getFileEncryptionInfo(ozoneManager, bucketInfo);
+ omKeyInfo = prepareKeyInfo(omMetadataManager, keyArgs, dbKeyName,
+ keyArgs.getDataSize(), locations, encryptionInfo);
+ } catch (IOException ex) {
+ LOG.error("Key open failed for volume:{} bucket:{} key:{}",
+ volumeName, bucketName, keyName, ex);
+ exception = ex;
+ } finally {
+ omMetadataManager.getLock().releaseBucketLock(volumeName, bucketName);
+ }
+
+
+ if (exception == null) {
+ if (omKeyInfo == null) {
+ // the key does not exist, create a new object, the new blocks are the
+ // version 0
+ omKeyInfo = createKeyInfo(keyArgs, locations, keyArgs.getFactor(),
+ keyArgs.getType(), keyArgs.getDataSize(),
+ encryptionInfo);
+ }
+
+ openVersion = omKeyInfo.getLatestVersionLocations().getVersion();
+
+ try {
+ omKeyInfo.appendNewBlocks(keyArgs.getKeyLocationsList().stream()
+ .map(OmKeyLocationInfo::getFromProtobuf)
+ .collect(Collectors.toList()), false);
+
+ } catch (IOException ex) {
+ LOG.error("Open failed for Key: {} in volume/bucket:{}/{}",
+ keyName, bucketName, volumeName, ex);
+ omMetrics.incNumKeyAllocateFails();
+ auditLog(auditLogger, buildAuditMessage(OMAction.ALLOCATE_KEY,
auditMap,
+ ex, getOmRequest().getUserInfo()));
+ return new OMKeyCreateResponse(null, -1L,
+ createErrorOMResponse(omResponse, ex));
+ }
+
+ // Add to cache entry can be done outside of lock for this openKey.
+ // Even if bucket gets deleted, when commitKey we shall identify if
+ // bucket gets deleted.
+ omMetadataManager.getOpenKeyTable().addCacheEntry(
Review comment:
What if the same client sends 2 create key requests for same key? Could it
cause synchronization issues here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 264819)
> Implement Key Write Requests to use Cache and DoubleBuffer
> ----------------------------------------------------------
>
> Key: HDDS-1638
> URL: https://issues.apache.org/jira/browse/HDDS-1638
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Implement Key write requests to use OM Cache, double buffer.
> In this Jira will add the changes to implement key operations, and HA/Non-HA
> will have a different code path, but once all requests are implemented will
> have a single code path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
