[
https://issues.apache.org/jira/browse/HDDS-1685?focusedWorklogId=269590&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269590
]
ASF GitHub Bot logged work on HDDS-1685:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/19 22:26
Start Date: 28/Jun/19 22:26
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #987:
HDDS-1685. Recon: Add support for 'start' query param to containers…
URL: https://github.com/apache/hadoop/pull/987#discussion_r298765130
##########
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##########
@@ -69,16 +74,20 @@
/**
* Return @{@link org.apache.hadoop.ozone.recon.api.types.ContainerMetadata}
- * for all the containers.
+ * for the containers starting from the given "prev-key" query param for the
+ * given "limit". The given "prev-key" is skipped from the results returned.
*
+ * @param limit max no. of containers to get.
+ * @param prevKey the containerID after which results are returned.
* @return {@link Response}
*/
@GET
public Response getContainers(
- @DefaultValue("-1") @QueryParam("limit") int limit) {
+ @DefaultValue(FETCH_ALL) @QueryParam(RECON_QUERY_LIMIT) int limit,
+ @DefaultValue("0") @QueryParam(RECON_QUERY_PREVKEY) long prevKey) {
Review comment:
Minor NIT: Can we have a variable for this default value too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 269590)
Time Spent: 3h (was: 2h 50m)
> Recon: Add support for "start" query param to containers and containers/{id}
> endpoints
> --------------------------------------------------------------------------------------
>
> Key: HDDS-1685
> URL: https://issues.apache.org/jira/browse/HDDS-1685
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
> Affects Versions: 0.4.0
> Reporter: Vivek Ratnavel Subramanian
> Assignee: Vivek Ratnavel Subramanian
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> * Support "start" query param to seek to the given key in RocksDB.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
