[
https://issues.apache.org/jira/browse/HDDS-1685?focusedWorklogId=264941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264941
]
ASF GitHub Bot logged work on HDDS-1685:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/19 20:02
Start Date: 21/Jun/19 20:02
Worklog Time Spent: 10m
Work Description: avijayanhwx commented on pull request #987: HDDS-1685.
Recon: Add support for 'start' query param to containers…
URL: https://github.com/apache/hadoop/pull/987#discussion_r296376203
##########
File path:
hadoop-ozone/ozone-recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestContainerKeyService.java
##########
@@ -227,20 +227,38 @@ public void testGetKeysForContainer() {
assertEquals(blockIds.get(0L).iterator().next().getLocalID(), 103);
assertEquals(blockIds.get(1L).iterator().next().getLocalID(), 104);
- response = containerKeyService.getKeysForContainer(3L, -1);
+ response = containerKeyService.getKeysForContainer(3L, -1, "");
keyMetadataList = (Collection<KeyMetadata>) response.getEntity();
assertTrue(keyMetadataList.isEmpty());
// test if limit works as expected
- response = containerKeyService.getKeysForContainer(1L, 1);
+ response = containerKeyService.getKeysForContainer(1L, 1, "");
keyMetadataList = (Collection<KeyMetadata>) response.getEntity();
assertEquals(keyMetadataList.size(), 1);
+
+ // test if start param works as expected
+ response = containerKeyService.getKeysForContainer(
+ 1L, -1, "/sampleVol/bucketOne/key_one");
Review comment:
Are we testing all negative cases - Limit not being specified, Start key
prefix not found ? Maybe we can split this UT into multiple ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 264941)
Time Spent: 1h 40m (was: 1.5h)
> Recon: Add support for "start" query param to containers and containers/{id}
> endpoints
> --------------------------------------------------------------------------------------
>
> Key: HDDS-1685
> URL: https://issues.apache.org/jira/browse/HDDS-1685
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
> Affects Versions: 0.4.0
> Reporter: Vivek Ratnavel Subramanian
> Assignee: Vivek Ratnavel Subramanian
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> * Support "start" query param to seek to the given key in RocksDB.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
