[
https://issues.apache.org/jira/browse/HDDS-1611?focusedWorklogId=269638&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269638
]
ASF GitHub Bot logged work on HDDS-1611:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/19 00:17
Start Date: 29/Jun/19 00:17
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #973: HDDS-1611.
Evaluate ACL on volume bucket key and prefix to authorize access. Contributed
by Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/973#discussion_r298779110
##########
File path:
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/TestOzoneAcls.java
##########
@@ -103,8 +103,8 @@ public void testAclParse() {
testMatrix.put(" world::rw", Boolean.TRUE);
testMatrix.put(" world::a", Boolean.TRUE);
- testMatrix.put(" world:bilbo:w", Boolean.FALSE);
- testMatrix.put(" world:bilbo:rw", Boolean.FALSE);
+ testMatrix.put(" world:bilbo:w", Boolean.TRUE);
+ testMatrix.put(" world:bilbo:rw", Boolean.TRUE);
Review comment:
This is a good catch. I think we should move to more explicit error, where
if the users tries to set world and a user name, we should throw an error, that
way user is not making a mistake, which we are silently ignoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 269638)
Time Spent: 4h 50m (was: 4h 40m)
> Evaluate ACL on volume bucket key and prefix to authorize access
> -----------------------------------------------------------------
>
> Key: HDDS-1611
> URL: https://issues.apache.org/jira/browse/HDDS-1611
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Ajay Kumar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
