[
https://issues.apache.org/jira/browse/HDDS-1611?focusedWorklogId=269643&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269643
]
ASF GitHub Bot logged work on HDDS-1611:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/19 00:35
Start Date: 29/Jun/19 00:35
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #973: HDDS-1611.
Evaluate ACL on volume bucket key and prefix to authorize access. Contributed
by Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/973#discussion_r298780485
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -2276,11 +2325,21 @@ public void commitKey(OmKeyArgs args, long clientID)
@Override
public OmKeyLocationInfo allocateBlock(OmKeyArgs args, long clientID,
- ExcludeList excludeList)
- throws IOException {
+ ExcludeList excludeList) throws IOException {
if(isAclEnabled) {
- checkAcls(ResourceType.KEY, StoreType.OZONE, ACLType.WRITE,
- args.getVolumeName(), args.getBucketName(), args.getKeyName());
+ try {
+ checkAcls(ResourceType.KEY, StoreType.OZONE, ACLType.WRITE,
Review comment:
we need to make sure that Audit system knows about these ACL check failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 269643)
Time Spent: 5h (was: 4h 50m)
> Evaluate ACL on volume bucket key and prefix to authorize access
> -----------------------------------------------------------------
>
> Key: HDDS-1611
> URL: https://issues.apache.org/jira/browse/HDDS-1611
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Ajay Kumar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
