[ 
https://issues.apache.org/jira/browse/HDFS-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877789#comment-16877789
 ] 

Surendra Singh Lilhore commented on HDFS-14358:
-----------------------------------------------

Thanks [~hemanthboyina] for patch.

I have some comment 

1. This style is not required here.
{code}
+<style>
+.col-sm-6 {
+    width: 20%;
+}
+#dropDownStyle{
+    width:75px;
+    height:30px;
+    color: #555;
+    display: inline-block;
+    }
+
+</style>
{code}

2. "col-sm-6" directly you can as {{style="width:20%"}} in "<p>".
3. Move {{dropDownStyle}} to hadoop.css file and changed name to 
{{datanodestatus}}
4. Rename {{selectTriggerFilter}} to {{datanodefilter}}.
5. make {{initComplete}} function more readable.



> Provide LiveNode and DeadNode filter in DataNode UI
> ---------------------------------------------------
>
>                 Key: HDFS-14358
>                 URL: https://issues.apache.org/jira/browse/HDFS-14358
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.1.2
>            Reporter: Ravuri Sushma sree
>            Assignee: hemanthboyina
>            Priority: Major
>         Attachments: HDFS-14358(2).patch, HDFS-14358(3).patch, 
> hdfs-14358.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to