[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879443#comment-16879443
]
Íñigo Goiri commented on HDFS-14625:
------------------------------------
As we are moving it to a separate class, I think we can use this chance to make
some cleanup in the new DefaultAuditLogger:
* Make the fields protected and provide getters if needed. Even private if that
helps the OO pattern.
* We can remove the type in the constructor as {{public Set<String> debugCmdSet
= new HashSet<>();}}.
* Extra space in {{static class FSNamesystemAuditLogger extends
DefaultAuditLogger {}}.
* Add short javadocs to the interesting fields:
{code}
/** List of commands to provide debug messages. */
public Set<String> debugCmdSet = new HashSet<>();
{code}
> Make DefaultAuditLogger class in FSnamesystem to Abstract
> ----------------------------------------------------------
>
> Key: HDFS-14625
> URL: https://issues.apache.org/jira/browse/HDFS-14625
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: hemanthboyina
> Assignee: hemanthboyina
> Priority: Major
> Attachments: HDFS-14625 (1).patch, HDFS-14625.patch
>
>
> As per +HDFS-13270+ Audit logger for Router , we can make DefaultAuditLogger
> in FSnamesystem to be Abstract and common
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
