[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883104#comment-16883104
]
hemanthboyina commented on HDFS-14625:
--------------------------------------
thanks [~elgoiri] for the comments
* _I know it is painful to do this fully OO but can we switch from protected
to private and use getters in the child class? I think we need a couple setters
for them too._
variables should be protected to make used by child classes , if u make
variables private and use getters in child class , to store the variable values
you need to declare them again in child class
* _The package private methods should go as protected so child in other
packages can use them_
we can make methods protected , but
{code:java}
public abstract class DefaultAuditLogger extends HdfsAuditLogger{code}
the methods are inherited from hdfsauditlogger and auditlogger , so we cannot
reduce the visibility
We can make methods protected , so that we need to change access modifiers in
HdfsAuditLogger and AuditLogger . Okay with it ?
> Make DefaultAuditLogger class in FSnamesystem to Abstract
> ----------------------------------------------------------
>
> Key: HDFS-14625
> URL: https://issues.apache.org/jira/browse/HDFS-14625
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: hemanthboyina
> Assignee: hemanthboyina
> Priority: Major
> Attachments: HDFS-14625 (1).patch, HDFS-14625(2).patch,
> HDFS-14625.patch
>
>
> As per +HDFS-13270+ Audit logger for Router , we can make DefaultAuditLogger
> in FSnamesystem to be Abstract and common
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
