[
https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881687#comment-16881687
]
Yiqun Lin commented on HDFS-14632:
----------------------------------
LGTM, +1. Commit this shortly.
> Reduce useless #getNumLiveDataNodes call in SafeModeMonitor
> -----------------------------------------------------------
>
> Key: HDFS-14632
> URL: https://issues.apache.org/jira/browse/HDFS-14632
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: He Xiaoqiao
> Assignee: He Xiaoqiao
> Priority: Major
> Attachments: HDFS-14632.001.patch, HDFS-14632.002.patch,
> HDFS-14632.003.patch, HDFS-14632.004.patch, HDFS-14632.005.patch,
> HDFS-14632.006.patch
>
>
> As mentioned HDFS-14171, SafeModeMonitor invoke useless #getNumLiveDataNodes
> if not config DataNode threshold.
> The root cause is BlockManagerSafeMode#reportStatus(for trunk branch) or
> SafeModeInfo#reportStatus (for branch-2.8) print status every 20 seconds and
> invoke SafeModeInfo#getTurnOffTip.
> Optimize with checking if config DataNode threshold then decide to if get
> number of live DataNodes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
