[
https://issues.apache.org/jira/browse/HDDS-1544?focusedWorklogId=277150&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-277150
]
ASF GitHub Bot logged work on HDDS-1544:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/19 02:47
Start Date: 16/Jul/19 02:47
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #1101:
HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …
URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709426
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -983,6 +1019,44 @@ public OmMultipartInfo
applyInitiateMultipartUpload(OmKeyArgs keyArgs,
}
}
+ private List<OzoneAclInfo> getAclsForKey(OmKeyArgs keyArgs,
+ OmVolumeArgs volArgs, OmBucketInfo bucketInfo) {
+ List<OzoneAclInfo> acls = new ArrayList<>(keyArgs.getAcls().size());
+
+ keyArgs.getAcls().stream().map(OzoneAcl::toProtobuf).
+ collect(Collectors.toList());
+
+ // Inherit DEFAULT acls from prefix.
+ boolean prefixParentFound = false;
+ if(prefixManager != null) {
+ List<OmPrefixInfo> prefixList = prefixManager.getLongestPrefixPath(
+ OZONE_URI_DELIMITER +
+ keyArgs.getVolumeName() + OZONE_URI_DELIMITER +
+ keyArgs.getBucketName() + OZONE_URI_DELIMITER +
+ keyArgs.getKeyName());
+
+ if(prefixList.size() > 0) {
+ // Add all acls from direct parent to key.
+ OmPrefixInfo prefixInfo = prefixList.get(prefixList.size() - 1);
+ if(prefixInfo != null) {
+ acls.addAll(OzoneUtils.getDefaultAclsProto(prefixInfo.getAcls()));
+ prefixParentFound = true;
+ }
+ }
+ }
+
+ // Inherit DEFAULT acls from bucket only if DEFAULT acls for
+ // prefix are not set.
+ if (!prefixParentFound && bucketInfo != null) {
+ acls.addAll(bucketInfo.getAcls().stream().filter(a -> a.getAclScope()
+ .equals(OzoneAcl.AclScope.DEFAULT))
+ .map(OzoneAcl::toProtobufWithAccessType)
+ .collect(Collectors.toList()));
+ }
Review comment:
whitespace:end of line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 277150)
Time Spent: 13h (was: 12h 50m)
> Support default Acls for volume, bucket, keys and prefix
> --------------------------------------------------------
>
> Key: HDDS-1544
> URL: https://issues.apache.org/jira/browse/HDDS-1544
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Xiaoyu Yao
> Priority: Major
> Labels: pull-request-available
> Attachments: HDDS-1544.00.patch
>
> Time Spent: 13h
> Remaining Estimate: 0h
>
> Add dAcls for volume, bucket, keys and prefix
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
