[
https://issues.apache.org/jira/browse/HDDS-1544?focusedWorklogId=277156&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-277156
]
ASF GitHub Bot logged work on HDDS-1544:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/19 02:49
Start Date: 16/Jul/19 02:49
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #1101:
HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …
URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709384
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
##########
@@ -2279,7 +2332,42 @@ public void testNativeAclsForKey() throws Exception {
.setStoreType(OzoneObj.StoreType.OZONE)
.build();
- validateOzoneAcl(ozObj);
+ // Validates access acls.
+ validateOzoneAccessAcl(ozObj);
+
+ // Check default acls inherited from bucket.
+ OzoneObj buckObj = new OzoneObjInfo.Builder()
+ .setVolumeName(volumeName)
+ .setBucketName(bucketName)
+ .setKeyName(key1)
+ .setResType(OzoneObj.ResourceType.BUCKET)
+ .setStoreType(OzoneObj.StoreType.OZONE)
+ .build();
+
+ validateDefaultAcls(buckObj, ozObj, null, bucket);
+
+ // Check default acls inherited from prefix.
+ OzoneObj prefixObj = new OzoneObjInfo.Builder()
+ .setVolumeName(volumeName)
+ .setBucketName(bucketName)
+ .setKeyName(key1)
+ .setPrefixName("dir1/")
+ .setResType(OzoneObj.ResourceType.PREFIX)
+ .setStoreType(OzoneObj.StoreType.OZONE)
+ .build();
+ store.setAcl(prefixObj, getAclList(new OzoneConfiguration()));
+ // Prefix should inherit DEFAULT acl from bucket.
+
+ List<OzoneAcl> acls = store.getAcl(prefixObj);
+ assertTrue("Current acls:" + StringUtils.join(",", acls),
+ acls.contains(inheritedUserAcl));
+ assertTrue("Current acls:" + StringUtils.join(",", acls),
+ acls.contains(inheritedGroupAcl));
+ // Remove inherited acls from prefix.
+ assertTrue(store.removeAcl(prefixObj, inheritedUserAcl));
+ assertTrue(store.removeAcl(prefixObj, inheritedGroupAcl));
Review comment:
whitespace:end of line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 277156)
Time Spent: 14h (was: 13h 50m)
> Support default Acls for volume, bucket, keys and prefix
> --------------------------------------------------------
>
> Key: HDDS-1544
> URL: https://issues.apache.org/jira/browse/HDDS-1544
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Xiaoyu Yao
> Priority: Major
> Labels: pull-request-available
> Attachments: HDDS-1544.00.patch
>
> Time Spent: 14h
> Remaining Estimate: 0h
>
> Add dAcls for volume, bucket, keys and prefix
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
