[
https://issues.apache.org/jira/browse/HDDS-1488?focusedWorklogId=288518&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-288518
]
ASF GitHub Bot logged work on HDDS-1488:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/19 07:27
Start Date: 04/Aug/19 07:27
Worklog Time Spent: 10m
Work Description: nandakumar131 commented on pull request #1221:
HDDS-1488. Scm cli command to start/stop replication manager.
URL: https://github.com/apache/hadoop/pull/1221#discussion_r310374189
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
##########
@@ -469,6 +469,27 @@ public boolean forceExitSafeMode() throws IOException {
return scm.exitSafeMode();
}
+ @Override
+ public void startReplicationManager() {
+ AUDIT.logWriteSuccess(buildAuditMessageForSuccess(
+ SCMAction.START_REPLICATION_MANAGER, null));
+ scm.getReplicationManager().start();
+ }
+
+ @Override
+ public void stopReplicationManager() {
+ AUDIT.logWriteSuccess(buildAuditMessageForSuccess(
+ SCMAction.STOP_REPLICATION_MANAGER, null));
+ scm.getReplicationManager().stop();
Review comment:
Stop is an idempotent call and also it's async, so getting status of
ReplicationManager immediately after calling stop might some time return true
(running).
> Like case calling stop on already stopped replication monitor, we can
print like Replication Monitor is not running
If we do this, we can end up in a minor inconsistency for a short period of
time. Where stop will say that ReplicationManager is not running, but the
status command will say that ReplicationManager is running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 288518)
Time Spent: 40m (was: 0.5h)
> Scm cli command to start/stop replication manager
> -------------------------------------------------
>
> Key: HDDS-1488
> URL: https://issues.apache.org/jira/browse/HDDS-1488
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It would be nice to have scmcli command to start/stop the ReplicationManager
> thread running in SCM
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
