[
https://issues.apache.org/jira/browse/HDDS-1488?focusedWorklogId=288626&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-288626
]
ASF GitHub Bot logged work on HDDS-1488:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/19 22:21
Start Date: 04/Aug/19 22:21
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1221:
HDDS-1488. Scm cli command to start/stop replication manager.
URL: https://github.com/apache/hadoop/pull/1221#discussion_r310406193
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
##########
@@ -469,6 +469,27 @@ public boolean forceExitSafeMode() throws IOException {
return scm.exitSafeMode();
}
+ @Override
+ public void startReplicationManager() {
+ AUDIT.logWriteSuccess(buildAuditMessageForSuccess(
+ SCMAction.START_REPLICATION_MANAGER, null));
+ scm.getReplicationManager().start();
+ }
+
+ @Override
+ public void stopReplicationManager() {
+ AUDIT.logWriteSuccess(buildAuditMessageForSuccess(
+ SCMAction.STOP_REPLICATION_MANAGER, null));
+ scm.getReplicationManager().stop();
Review comment:
This is true, even if we don't return status, as stop() is not a blocking
call.
Can we print some output message for the command for stop like we signalled
for stop, and if immediately status is called you can still see it as running.
(Or something more clearer, to let users know the behavior)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 288626)
Time Spent: 50m (was: 40m)
> Scm cli command to start/stop replication manager
> -------------------------------------------------
>
> Key: HDDS-1488
> URL: https://issues.apache.org/jira/browse/HDDS-1488
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> It would be nice to have scmcli command to start/stop the ReplicationManager
> thread running in SCM
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
