[
https://issues.apache.org/jira/browse/HDFS-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138624#comment-13138624
]
Tsz Wo (Nicholas), SZE commented on HDFS-2436:
----------------------------------------------
Hi Uma, the patch looks good.
The new getINode(..) does not have to check null. The existing
getFileINode(..) should use getINode(..) and do not have to acquire the read
lock, i.e.
{code}
INodeFile getFileINode(String src) throws UnresolvedLinkException {
INode inode = getINode(src);
if (inode == null || inode.isDirectory())
return null;
assert !inode.isLink();
return (INodeFile)inode;
}
{code}
> FSNamesystem.setTimes(..) expects the path is a file.
> -----------------------------------------------------
>
> Key: HDFS-2436
> URL: https://issues.apache.org/jira/browse/HDFS-2436
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2436.patch, HDFS-2436.patch
>
>
> FSNamesystem.setTimes(..) does not work if the path is a directory.
> Arpit found this bug when testing webhdfs:
> {quote}
> settimes api is working when called on a file, but when called on a dir it
> returns a 404. I should be able to set time on both a file and a directory.
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
