[ 
https://issues.apache.org/jira/browse/HDFS-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138686#comment-13138686
 ] 

Uma Maheswara Rao G commented on HDFS-2436:
-------------------------------------------

Hi Nicholas, Thanks a lot for the review!

Yes, no use with that null check. I might missed while just removing the 
inode.isDirectory() check. Thanks for noticing.

Updated the patch with the comment fix.

Thanks
Uma
                
> FSNamesystem.setTimes(..) expects the path is a file.
> -----------------------------------------------------
>
>                 Key: HDFS-2436
>                 URL: https://issues.apache.org/jira/browse/HDFS-2436
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.20.205.0
>            Reporter: Arpit Gupta
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-2436.patch, HDFS-2436.patch, HDFS-2436.patch
>
>
> FSNamesystem.setTimes(..) does not work if the path is a directory.
> Arpit found this bug when testing webhdfs:
> {quote}
> settimes api is working when called on a file, but when called on a dir it 
> returns a 404. I should be able to set time on both a file and a directory.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to