[
https://issues.apache.org/jira/browse/HDDS-2022?focusedWorklogId=300406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300406
]
ASF GitHub Bot logged work on HDDS-2022:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Aug/19 17:35
Start Date: 23/Aug/19 17:35
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#issuecomment-524399971
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 98 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 650 | trunk passed |
| +1 | compile | 362 | trunk passed |
| +1 | checkstyle | 65 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 823 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 152 | trunk passed |
| 0 | spotbugs | 420 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 609 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 549 | the patch passed |
| +1 | compile | 362 | the patch passed |
| +1 | javac | 362 | the patch passed |
| +1 | checkstyle | 69 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 2 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 671 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 152 | the patch passed |
| -1 | findbugs | 426 | hadoop-ozone generated 6 new + 0 unchanged - 0 fixed
= 6 total (was 0) |
||| _ Other Tests _ |
| -1 | unit | 219 | hadoop-hdds in the patch failed. |
| -1 | unit | 2613 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 43 | The patch does not generate ASF License warnings. |
| | | 8234 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-ozone |
| | Possible null pointer dereference of volume in
org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration,
String, String) on exception path Dereferenced at
BaseFreonGenerator.java:volume in
org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration,
String, String) on exception path Dereferenced at
BaseFreonGenerator.java:[line 263] |
| | Unused field:OzoneClientKeyValidator.java |
| | Unused field:OzoneClientKeyValidator.java |
| | Dead store to configuration in
org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At
S3KeyGenerator.java:org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At
S3KeyGenerator.java:[line 78] |
| | Unused field:SameKeyReader.java |
| | Unused field:SameKeyReader.java |
| Failed junit tests | hadoop.ozone.container.ozoneimpl.TestOzoneContainer |
| | hadoop.ozone.container.server.TestSecureContainerServer |
| | hadoop.ozone.TestStorageContainerManager |
| | hadoop.ozone.client.rpc.TestCommitWatcher |
| | hadoop.ozone.client.rpc.Test2WayCommitInRatis |
| | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1341 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml findbugs checkstyle |
| uname | Linux 03d0f0374a50 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / c92de82 |
| Default Java | 1.8.0_222 |
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/2/artifact/out/new-findbugs-hadoop-ozone.html
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/2/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/2/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/2/testReport/ |
| Max. process+thread count | 4876 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/tools U: hadoop-ozone/tools |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/2/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 300406)
Time Spent: 50m (was: 40m)
> Add additional freon tests
> --------------------------
>
> Key: HDDS-2022
> URL: https://issues.apache.org/jira/browse/HDDS-2022
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Tools
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Freon is a generic load generator tool for ozone (ozone freon) which supports
> multiple generation pattern.
> As of now only the random-key-generator is implemented which uses ozone rpc
> client.
> It would be great to add additional tests:
> * Test key generation via s3 interface
> * Test key generation via the hadoop fs interface
> * Test key reads (validation)
> * Test OM with direct RPC calls
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
