[
https://issues.apache.org/jira/browse/HDDS-2022?focusedWorklogId=301335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301335
]
ASF GitHub Bot logged work on HDDS-2022:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/19 16:38
Start Date: 26/Aug/19 16:38
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1341: HDDS-2022.
Add additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317563960
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SameKeyReader.java
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.InputStream;
+import java.security.MessageDigest;
+import java.util.concurrent.Callable;
+
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.client.OzoneBucket;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.io.IOUtils;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
+/**
+ * Data generator tool test om performance.
+ */
+@Command(name = "ocokr",
+ aliases = "ozone-client-one-key-reader",
+ description = "Read the same key from multiple threads.",
+ versionProvider = HddsVersionProvider.class,
+ mixinStandardHelpOptions = true,
+ showDefaultValues = true)
+public class SameKeyReader extends BaseFreonGenerator
+ implements Callable<Void> {
+
+ @Option(names = {"-v", "--volume"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
+ defaultValue = "vol1")
+ private String volumeName;
+
+ @Option(names = {"-b", "--bucket"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
+ defaultValue = "bucket1")
+ private String bucketName;
+
+ @Option(names = {"-k", "--key"},
+ description = "Name of the key read from multiple threads",
+ defaultValue = "bucket1")
+ private String keyName;
+
+ private Timer timer;
+
+ private OzoneBucket bucket;
+
+ private ContentGenerator contentGenerator;
+
+ private byte[] referenceDigest;
+
+ private OzoneClient rpcClient;
+
+ @Override
+ public Void call() throws Exception {
+
+ init();
+
+ OzoneConfiguration ozoneConfiguration = createOzoneConfiguration();
+
+ rpcClient = OzoneClientFactory.getRpcClient(ozoneConfiguration);
+
+ try (InputStream stream = rpcClient.getObjectStore().getVolume(volumeName)
+ .getBucket(bucketName).readKey(keyName)) {
+ referenceDigest = getDigest(stream);
+ }
+
+ timer = getMetrics().timer("key-create");
Review comment:
```suggestion
timer = getMetrics().timer("key-validate");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 301335)
> Add additional freon tests
> --------------------------
>
> Key: HDDS-2022
> URL: https://issues.apache.org/jira/browse/HDDS-2022
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Tools
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Freon is a generic load generator tool for ozone (ozone freon) which supports
> multiple generation pattern.
> As of now only the random-key-generator is implemented which uses ozone rpc
> client.
> It would be great to add additional tests:
> * Test key generation via s3 interface
> * Test key generation via the hadoop fs interface
> * Test key reads (validation)
> * Test OM with direct RPC calls
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
