[ 
https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922553#comment-16922553
 ] 

Ayush Saxena commented on HDFS-14810:
-------------------------------------

Thanx [~hexiaoqiao]  for the patch.

{code:java}
-      logAuditEvent(false, operationName, snapshotRoot,
-          snapshotPath, null);
+      logAuditEvent(false, operationName, snapshotRoot);
{code}
Guess we shouldn't remove the snapshot path?

In AddErasureCodingPolicy, Can we eliminate the success variable? 
Apart from this Looks Good.

 

> review FSNameSystem editlog sync
> --------------------------------
>
>                 Key: HDFS-14810
>                 URL: https://issues.apache.org/jira/browse/HDFS-14810
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: He Xiaoqiao
>            Assignee: He Xiaoqiao
>            Priority: Major
>         Attachments: HDFS-14810.001.patch, HDFS-14810.002.patch, 
> HDFS-14810.003.patch
>
>
> refactor and unified type of edit log sync in FSNamesystem as HDFS-11246 
> mentioned.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to