[
https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922692#comment-16922692
]
He Xiaoqiao commented on HDFS-14810:
------------------------------------
Thanks [~ayushtkn] for your nice reviews.
1. I try to remove `snapshotPath` cause that it always null when meet
`AccessControlException`, so I think it is safe to remove when log audit.
2. about `AddErasureCodingPolicy`, I have added `success` based on `audit false
should be only for ACE` mentioned above. I just check it carefully just now,
and believe we could eliminate success variable since it looks set true always
no matter if meet exception or not, So we could remove it. Do you mind to help
double check? Thanks again.
> review FSNameSystem editlog sync
> --------------------------------
>
> Key: HDFS-14810
> URL: https://issues.apache.org/jira/browse/HDFS-14810
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: He Xiaoqiao
> Assignee: He Xiaoqiao
> Priority: Major
> Attachments: HDFS-14810.001.patch, HDFS-14810.002.patch,
> HDFS-14810.003.patch
>
>
> refactor and unified type of edit log sync in FSNamesystem as HDFS-11246
> mentioned.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
