[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927106#comment-16927106
]
Íñigo Goiri commented on HDFS-14837:
------------------------------------
Can we use EqualsBuilder and HashCodeBuilder?
I would also complete the javadocs instead of removing them.
For example for getBlockName() I would put an example of blk_XXXXX.
I always want to know which one is the one with the timestamp or the one
without; the javadoc would clarify that.
> Review of Block.java
> --------------------
>
> Key: HDFS-14837
> URL: https://issues.apache.org/jira/browse/HDFS-14837
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HDFS-14837.1.patch
>
>
> The {{Block}} class is such a core class in the project, I just wanted to
> make sure it was super clean and documentation was correct.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
