[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928937#comment-16928937
]
David Mollitor commented on HDFS-14837:
---------------------------------------
[~elgoiri] Thanks for the feed back!
{{EqualsBuider}} and {{HashCodeBuilder}} are overkill here because there is
only one or two fields to consider. Also, this {{Block}} class is used in many
{{HashMap}} and {{HashSet}} so performance of the hash code and equals matters
here.
I did put back in some comments. I hope they help. Feel free to update to
something that is meaningful and helpful to you after patch is committed.
> Review of Block.java
> --------------------
>
> Key: HDFS-14837
> URL: https://issues.apache.org/jira/browse/HDFS-14837
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HDFS-14837.1.patch, HDFS-14837.2.patch
>
>
> The {{Block}} class is such a core class in the project, I just wanted to
> make sure it was super clean and documentation was correct.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
