[ 
https://issues.apache.org/jira/browse/HDFS-14818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928209#comment-16928209
 ] 

Rakesh R edited comment on HDFS-14818 at 9/12/19 5:22 AM:
----------------------------------------------------------

Thanks [~PhiloHe] for the patch. Overall looks good to me, just few comments.
 # {{SupportState.PMDK_LIB_NOT_FOUND}} - its unused now, can you remove it.
{code:java}
SupportState.PMDK_LIB_NOT_FOUND(1),
{code}
{code:java}
 case 1:
 msg = "The native code is built with PMDK support, but PMDK libs " +
 "are NOT found in execution environment or failed to be loaded.";
 break;
{code}
# Any reason to change 'NAME' to 'REALPATH'.


was (Author: rakeshr):
Thanks [~PhiloHe] for the patch. Overall looks good to me, just a comment.

# {{SupportState.PMDK_LIB_NOT_FOUND}} - its unused now, can you remove it.
 {code}
SupportState.PMDK_LIB_NOT_FOUND(1),
{code}
{code}
 case 1:
 msg = "The native code is built with PMDK support, but PMDK libs " +
 "are NOT found in execution environment or failed to be loaded.";
 break;
{code}

> Check native pmdk lib by 'hadoop checknative' command
> -----------------------------------------------------
>
>                 Key: HDFS-14818
>                 URL: https://issues.apache.org/jira/browse/HDFS-14818
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: native
>            Reporter: Feilong He
>            Assignee: Feilong He
>            Priority: Major
>         Attachments: HDFS-14818.000.patch
>
>
> Currently, 'hadoop checknative' command supports checking native libs, such 
> as zlib, snappy, openssl and ISA-L etc. It's necessary to include pmdk lib in 
> the checking.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to