[
https://issues.apache.org/jira/browse/HDFS-14818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930216#comment-16930216
]
Feilong He edited comment on HDFS-14818 at 9/17/19 1:50 AM:
------------------------------------------------------------
Thanks [~rakeshr] for your comments.
To make the code change effect clear to reviewers, I posted some screenshots.
* The below picture shows the result of 'hadoop checknative' afer building
WITH PMDK. The build cmd is 'mvn clean package -Pdist,native -DskipTests -Dtar
-Drequire.pmdk'.
!check_native_after_building_with_PMDK.png!
* The below picture shows the result of 'hadoop checknative' afer building
WITHOUT PMDK. The build cmd is 'mvn clean package -Pdist,native -DskipTests
-Dtar'.
!check_native_after_building_without_PMDK.png!
* The below picture shows the result of 'hadoop checknative' afer building
WITH PMDK, but shading the modification brought by this patch for
CMakeLists.txt, i.e., still use 'NAME' instead of 'REALPATH'. The build cmd is
'mvn clean package -Pdist,native -DskipTests -Dtar -Drequire.pmdk'.
!check_native_after_building_with_PMDK_using_NAME_instead_of_REALPATH.png!
{quote}{{SupportState.PMDK_LIB_NOT_FOUND}} - its unused now, can you remove it.
{quote}
In some env, if the PMDK native lib is not found, this state and its message
will help user to identify the fact. So I am leaning to keep this state.
{quote}Any reason to change 'NAME' to 'REALPATH'.
{quote}
As the above 3rd picture shows, if 'NAME' is used instead of ‘REALPATH', only
the lib name can be obtained and then printed by 'hadoop checknative'. In this
patch, by using 'REALPATH', the real path of the target lib will be kept, which
is more useful to user, I think.
Please refer to
[https://cmake.org/cmake/help/v3.15/command/get_filename_component.html].
was (Author: philohe):
Thanks [~rakeshr] for your comments.
To make the code change effect clear to reviewers, I posted some screenshots.
* The below picture shows the result of 'hadoop checknative' afer building
WITH PMDK. The build cmd is 'mvn clean package -Pdist,native -DskipTests -Dtar
-Drequire.pmdk'.
!check_native_after_building_with_PMDK.png!
* The below picture shows the result of 'hadoop checknative' afer building
WITHOUT PMDK. The build cmd is 'mvn clean package -Pdist,native -DskipTests
-Dtar'.
!check_native_after_building_without_PMDK.png!
* The below picture shows the result of 'hadoop checknative' afer building
WITH PMDK, but shading the modification brought by this patch for
CMakeLists.txt, i.e., still use 'NAME' instead of 'REALPATH'. The build cmd is
'mvn clean package -Pdist,native -DskipTests -Dtar -Drequire.pmdk'.
!check_native_after_building_with_PMDK_using_NAME_instead_of_REALPATH.png!
{quote}{{SupportState.PMDK_LIB_NOT_FOUND}} - its unused now, can you remove it.
{quote}
In some env, if the PMDK native lib is nout found, this state and its message
will help user to identify the fact. So I am leaning to keep this state.
{quote}Any reason to change 'NAME' to 'REALPATH'.
{quote}
As the above 3rd picture shows, if 'NAME' is used instead of ‘REALPATH', only
the lib name can be obtained and then printed by 'hadoop checknative'. In this
patch, by using 'REALPATH', the real path of the target lib will be kept, which
is more useful to user, I think.
Please refer to
[https://cmake.org/cmake/help/v3.15/command/get_filename_component.html].
> Check native pmdk lib by 'hadoop checknative' command
> -----------------------------------------------------
>
> Key: HDFS-14818
> URL: https://issues.apache.org/jira/browse/HDFS-14818
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: native
> Reporter: Feilong He
> Assignee: Feilong He
> Priority: Major
> Attachments: HDFS-14818.000.patch, HDFS-14818.001.patch,
> check_native_after_building_with_PMDK.png,
> check_native_after_building_with_PMDK_using_NAME_instead_of_REALPATH.png,
> check_native_after_building_without_PMDK.png
>
>
> Currently, 'hadoop checknative' command supports checking native libs, such
> as zlib, snappy, openssl and ISA-L etc. It's necessary to include pmdk lib in
> the checking.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
