[
https://issues.apache.org/jira/browse/HDDS-2067?focusedWorklogId=316604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316604
]
ASF GitHub Bot logged work on HDDS-2067:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/19 11:09
Start Date: 23/Sep/19 11:09
Worklog Time Spent: 10m
Work Description: elek commented on issue #1501: HDDS-2067. Create
generic service facade with tracing/metrics/logging support
URL: https://github.com/apache/hadoop/pull/1501#issuecomment-534054232
This patch is nothing more just a code move. The common part from ozone
StorageContainerLocationProtocolServerSideTranslatorPB and
ScmBlockLocationProtocolServerSideTranslatorPB is moved to
OzoneProtocolMessageDispatcher.
As OzoneProtocolMessageDispatcher is part of the framework (which is the
tricky name of server-common) the translators are moved to the server project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 316604)
Time Spent: 20m (was: 10m)
> Create generic service facade with tracing/metrics/logging support
> ------------------------------------------------------------------
>
> Key: HDDS-2067
> URL: https://issues.apache.org/jira/browse/HDDS-2067
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We started to use a message based GRPC approach. Wen have only one method and
> the requests are routed based on a "type" field in the proto message.
> For example in OM protocol:
> {code}
> /**
> The OM service that takes care of Ozone namespace.
> */
> service OzoneManagerService {
> // A client-to-OM RPC to send client requests to OM Ratis server
> rpc submitRequest(OMRequest)
> returns(OMResponse);
> }
> {code}
> And
> {code}
> message OMRequest {
> required Type cmdType = 1; // Type of the command
> ...
> {code}
> This approach makes it possible to use the same code to process incoming
> messages in the server side.
> ScmBlockLocationProtocolServerSideTranslatorPB.send method contains the logic
> of:
> * Logging the request/response message (can be displayed with ozone insight)
> * Updated metrics
> * Handle open tracing context propagation.
> These functions are generic. For example
> OzoneManagerProtocolServerSideTranslatorPB use the same (=similar) code.
> The goal in this jira is to provide a generic utility and move the common
> code for tracing/request logging/response logging/metrics calculation to a
> common utility which can be used from all the ServerSide translators.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
