[
https://issues.apache.org/jira/browse/HDDS-2237?focusedWorklogId=322729&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322729
]
ASF GitHub Bot logged work on HDDS-2237:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Oct/19 16:32
Start Date: 03/Oct/19 16:32
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on issue #1584: HDDS-2237.
KeyDeletingService throws NPE if it's started too early
URL: https://github.com/apache/hadoop/pull/1584#issuecomment-538022115
Thanks for catching this. LGTM. There is a test failure
TestKeyDeletingService can you verify if it is related?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 322729)
Time Spent: 0.5h (was: 20m)
> KeyDeletingService throws NPE if it's started too early
> -------------------------------------------------------
>
> Key: HDDS-2237
> URL: https://issues.apache.org/jira/browse/HDDS-2237
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: om
> Reporter: Marton Elek
> Assignee: Marton Elek
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> 1. OzoneManager starts KeyManager
> 2. KeyManager starts KeyDeletingService
> 3. KeyDeletingService uses OzoneManager.isLeader()
> 4. OzoneManager.isLeader() uses omRatisServer
> 5. omRatisServer can be null (bumm)
>
> Now the initialization order in OzoneManager:
>
> new KeymanagerServer() *Includes start()!!!!*
> omRatisServer initialization
> start() (includes KeyManager.start())
>
> The solution seems to be easy: start the key manager only from the
> OzoneManager.start() and not from the OzoneManager.instantiateServices()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
