[
https://issues.apache.org/jira/browse/HDDS-2237?focusedWorklogId=323457&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323457
]
ASF GitHub Bot logged work on HDDS-2237:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/19 15:09
Start Date: 04/Oct/19 15:09
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1584: HDDS-2237.
KeyDeletingService throws NPE if it's started too early
URL: https://github.com/apache/hadoop/pull/1584#issuecomment-538438155
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 41 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| -1 | mvninstall | 30 | hadoop-hdds in trunk failed. |
| -1 | mvninstall | 33 | hadoop-ozone in trunk failed. |
| -1 | compile | 21 | hadoop-hdds in trunk failed. |
| -1 | compile | 15 | hadoop-ozone in trunk failed. |
| +1 | checkstyle | 48 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 871 | branch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 23 | hadoop-hdds in trunk failed. |
| -1 | javadoc | 20 | hadoop-ozone in trunk failed. |
| 0 | spotbugs | 969 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| -1 | findbugs | 32 | hadoop-hdds in trunk failed. |
| -1 | findbugs | 19 | hadoop-ozone in trunk failed. |
||| _ Patch Compile Tests _ |
| -1 | mvninstall | 35 | hadoop-hdds in the patch failed. |
| -1 | mvninstall | 37 | hadoop-ozone in the patch failed. |
| -1 | compile | 25 | hadoop-hdds in the patch failed. |
| -1 | compile | 20 | hadoop-ozone in the patch failed. |
| -1 | javac | 25 | hadoop-hdds in the patch failed. |
| -1 | javac | 20 | hadoop-ozone in the patch failed. |
| +1 | checkstyle | 56 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 719 | patch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 22 | hadoop-hdds in the patch failed. |
| -1 | javadoc | 20 | hadoop-ozone in the patch failed. |
| -1 | findbugs | 32 | hadoop-hdds in the patch failed. |
| -1 | findbugs | 21 | hadoop-ozone in the patch failed. |
||| _ Other Tests _ |
| -1 | unit | 28 | hadoop-hdds in the patch failed. |
| -1 | unit | 26 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 34 | The patch does not generate ASF License warnings. |
| | | 2367 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1584 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 482bb984fa76 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 531cc93 |
| Default Java | 1.8.0_222 |
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/branch-mvninstall-hadoop-hdds.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/branch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/branch-compile-hadoop-hdds.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/branch-compile-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/branch-javadoc-hadoop-hdds.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/branch-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/branch-findbugs-hadoop-hdds.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/branch-findbugs-hadoop-ozone.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-mvninstall-hadoop-hdds.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-compile-hadoop-hdds.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-compile-hadoop-ozone.txt
|
| javac |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-compile-hadoop-hdds.txt
|
| javac |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-compile-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-javadoc-hadoop-hdds.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-findbugs-hadoop-hdds.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-findbugs-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/testReport/ |
| Max. process+thread count | 447 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1584/2/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 323457)
Time Spent: 50m (was: 40m)
> KeyDeletingService throws NPE if it's started too early
> -------------------------------------------------------
>
> Key: HDDS-2237
> URL: https://issues.apache.org/jira/browse/HDDS-2237
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: om
> Reporter: Marton Elek
> Assignee: Marton Elek
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> 1. OzoneManager starts KeyManager
> 2. KeyManager starts KeyDeletingService
> 3. KeyDeletingService uses OzoneManager.isLeader()
> 4. OzoneManager.isLeader() uses omRatisServer
> 5. omRatisServer can be null (bumm)
>
> Now the initialization order in OzoneManager:
>
> new KeymanagerServer() *Includes start()!!!!*
> omRatisServer initialization
> start() (includes KeyManager.start())
>
> The solution seems to be easy: start the key manager only from the
> OzoneManager.start() and not from the OzoneManager.instantiateServices()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
