[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955288#comment-16955288
]
Ayush Saxena commented on HDFS-14284:
-------------------------------------
I checked it doesn't throw NPE, But just prints {{null from router null}},
since we aren't setting the {{msg}} variable in the constructor, even the
message is lost.
I don't think that is something correct behavior either we don't have this
constructor or handle this in some better way.
[~elgoiri] any opinion?
The {{testRouterIOException}} doesn't test {{RouterIOException}} it tests
{{NoNamenodeException}}. Better change the name.
The {{RouterIOException}} isn't tested anywhere..
> RBF: Log Router identifier when reporting exceptions
> ----------------------------------------------------
>
> Key: HDFS-14284
> URL: https://issues.apache.org/jira/browse/HDFS-14284
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: hemanthboyina
> Priority: Major
> Attachments: HDFS-14284.001.patch, HDFS-14284.002.patch,
> HDFS-14284.003.patch, HDFS-14284.004.patch, HDFS-14284.005.patch,
> HDFS-14284.006.patch
>
>
> The typical setup is to use multiple Routers through
> ConfiguredFailoverProxyProvider.
> In a regular HA Namenode setup, it is easy to know which NN was used.
> However, in RBF, any Router can be the one reporting the exception and it is
> hard to know which was the one.
> We should have a way to identify which Router/Namenode was the one triggering
> the exception.
> This would also apply with Observer Namenodes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
