[
https://issues.apache.org/jira/browse/HDFS-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955449#comment-16955449
]
Ayush Saxena commented on HDFS-13736:
-------------------------------------
Thanx [~xiaodong.hu] for the patch.
I think the introduced test failed, You need to check it once.
bq. If just add a parameter to chooseLocalStorage to denote it, I think lots
of places should be modified.
I tried the approach, I don't think there are two places to tweek and in the
end it landed up quite a less number of lines than the present patch. I think
adding parameter would be a cleaner approach. If you are using an IDE, you can
use the refactor option to add new param to the method, it shall automatically
update all the places using it, with the default value passed.
Let me know for any help, if you are facing any trouble..
> BlockPlacementPolicyDefault can not choose favored nodes when
> 'dfs.namenode.block-placement-policy.default.prefer-local-node' set to false
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-13736
> URL: https://issues.apache.org/jira/browse/HDFS-13736
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: hu xiaodong
> Assignee: hu xiaodong
> Priority: Major
> Attachments: HDFS-13736.001.patch, HDFS-13736.002.patch
>
>
> BlockPlacementPolicyDefault can not choose favored nodes when
> 'dfs.namenode.block-placement-policy.default.prefer-local-node' set to false.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
