[ 
https://issues.apache.org/jira/browse/HDFS-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955887#comment-16955887
 ] 

Xiaoqiao He commented on HDFS-14915:
------------------------------------

Thanks [~ayushtkn] for your quick update. We need double #checkOperation both 
before and after hold lock.  For #reencryptEncryptionZone, there are three 
times to do #checkOperation(WRITE) and distributed on three method. Some of 
them are duplicated. What I means is that we should delete some duplicated 
checking and it is better to embrace in one method (or file another JIRA to 
track). FYI.
LGTM about superuser privilege checking improvement.

> Move Superuser Check Before Taking Lock For Encryption API
> ----------------------------------------------------------
>
>                 Key: HDFS-14915
>                 URL: https://issues.apache.org/jira/browse/HDFS-14915
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-14915-01.patch, HDFS-14915-02.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to