[ https://issues.apache.org/jira/browse/HDFS-14958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968458#comment-16968458 ]
Jim Brennan commented on HDFS-14958: ------------------------------------ In the DatanodeManager constructor: {noformat} this.useDfsNetworkTopology = conf.getBoolean( DFSConfigKeys.DFS_USE_DFS_NETWORK_TOPOLOGY_KEY, DFSConfigKeys.DFS_USE_DFS_NETWORK_TOPOLOGY_DEFAULT); if (useDfsNetworkTopology) { networktopology = DFSNetworkTopology.getInstance(conf); } else { networktopology = NetworkTopology.getInstance(conf); } And in DFSNetworkTopology.getInstance(): public static DFSNetworkTopology getInstance(Configuration conf) { DFSNetworkTopology nt = ReflectionUtils.newInstance(conf.getClass( DFSConfigKeys.DFS_NET_TOPOLOGY_IMPL_KEY, DFSConfigKeys.DFS_NET_TOPOLOGY_IMPL_DEFAULT, DFSNetworkTopology.class), conf); return (DFSNetworkTopology) nt.init(DFSTopologyNodeImpl.FACTORY); } {noformat} > TestBalancerWithNodeGroup is not using NetworkTopologyWithNodeGroup > ------------------------------------------------------------------- > > Key: HDFS-14958 > URL: https://issues.apache.org/jira/browse/HDFS-14958 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs > Affects Versions: 3.1.3 > Reporter: Jim Brennan > Priority: Minor > > TestBalancerWithNodeGroup is intended to test with > {{NetworkTopologyWithNodeGroup}}, but it is not configured correctly. > Because {{DFSConfigKeys.DFS_USE_DFS_NETWORK_TOPOLOGY_KEY}} defaults to true, > {{CommonConfigurationKeysPublic.NET_TOPOLOGY_IMPL_KEY}} is ignored and the > test actually uses the default {{DFSNetworkTopology}}. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org