[
https://issues.apache.org/jira/browse/HDFS-14958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968653#comment-16968653
]
Jim Brennan commented on HDFS-14958:
------------------------------------
[~inigoiri] I agree. I think this test pre-dates DFSNetworkTopology, so
perhaps it did work originally. I tried changing it to use NetworkTopology and
one of the test fails in that case, so it does differentiate between
NetworkTopology and NetworkTopologyWithNodeGroup. They just all succeed with
the default DFSNetworkTopology, which is why we missed this.
Should we file another Jira to improve this test?
The unit tests that failed appear to be unrelated to this patch:
{noformat}
[ERROR] Failures:
[ERROR] TestMultipleNNPortQOP.testMultipleNNPortOverwriteDownStream:177
expected:<auth> but was:<null>
[ERROR] TestRollingUpgrade.testRollback:354 Test resulted in an unexpected
exit
[ERROR] TestBalancer.testMaxIterationTime:1649 Unexpected iteration runtime:
4008ms > 3.5s
[ERROR] TestRedudantBlocks.testProcessOverReplicatedAndRedudantBlock:138
expected:<5> but was:<4>
{noformat}
> TestBalancerWithNodeGroup is not using NetworkTopologyWithNodeGroup
> -------------------------------------------------------------------
>
> Key: HDFS-14958
> URL: https://issues.apache.org/jira/browse/HDFS-14958
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Affects Versions: 3.1.3
> Reporter: Jim Brennan
> Assignee: Jim Brennan
> Priority: Minor
> Attachments: HDFS-14958.001.patch
>
>
> TestBalancerWithNodeGroup is intended to test with
> {{NetworkTopologyWithNodeGroup}}, but it is not configured correctly.
> Because {{DFSConfigKeys.DFS_USE_DFS_NETWORK_TOPOLOGY_KEY}} defaults to true,
> {{CommonConfigurationKeysPublic.NET_TOPOLOGY_IMPL_KEY}} is ignored and the
> test actually uses the default {{DFSNetworkTopology}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
