[ 
https://issues.apache.org/jira/browse/HDFS-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975408#comment-16975408
 ] 

Chao Sun commented on HDFS-14991:
---------------------------------

It seems you've combined changes in multiple JIRAs into one, such as 
HDFS-12085, HADOOP-16265, and so on. If that's the intention, I think it should 
be fine. A few minor comments:
1. Can we add the test brought in by HDFS-12085?
2. Can we also incorporate HDFS-14630 and remove the unnecessary log message?

Other than these this LGTM.

> Backport HDFS-14346 Better time precision in getTimeDuration to branch-2
> ------------------------------------------------------------------------
>
>                 Key: HDFS-14991
>                 URL: https://issues.apache.org/jira/browse/HDFS-14991
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Major
>         Attachments: HDFS-14991-branch-2.001.patch
>
>
> This is to backport HDFS-14346 to branch 2, as Standby reads in branch-2 
> requires being able to properly specify ms time granularity for Edit log 
> tailing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to