[ 
https://issues.apache.org/jira/browse/HDFS-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975460#comment-16975460
 ] 

Chen Liang edited comment on HDFS-14991 at 11/15/19 11:06 PM:
--------------------------------------------------------------

Thanks for the comments! I posted v002 patch, trying to include only HDFS-14346 
and HADOOP-16265. Not entirely the same as the two Jiras though, due to the 
dependency on other ones. 

One thing I hesitated was that, HDFS-14346 has several changes on the usage of 
{{getTimeDuration()}} in caller classes, but those changes were actually based 
on previous changes from HDFS-9847, which do not exist in branch-2. But I would 
like to still keep the changes to {{EditLogLoader}}, because, as mentioned in 
description, this particular part is required for SBN read...and I'm not sure 
if we will be backporting HDFS-9847. So what I did in v002 patch is to include 
only the changes on {{EditLogLoader}}. Please let me know if you have other 
preferences (and will update description/summary to reflect the changes later),


was (Author: vagarychen):
Thanks for the comments! I posted v002 patch, trying to include only HDFS-14346 
and HADOOP-16265. Not entirely the same as the two Jiras though, due to the 
dependency on other ones. 

One thing I hesitated was that, HDFS-14346 has several changes on the usage of 
{{getTimeDuration()}} in caller classes, but those changes were actually based 
on previous changes from HDFS-9847, which do not exist in branch-2. But I would 
like to still keep the changes to {{EditLogLoader}}, because, as mentioned in 
description, this particular part is required for SBN read...What I did in v002 
patch is to include only the changes on {{EditLogLoader}}. Please let me know 
if you have other preferences (and will update description/summary to reflect 
the changes later),

> Backport HDFS-14346 Better time precision in getTimeDuration to branch-2
> ------------------------------------------------------------------------
>
>                 Key: HDFS-14991
>                 URL: https://issues.apache.org/jira/browse/HDFS-14991
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Major
>         Attachments: HDFS-14991-branch-2.001.patch, 
> HDFS-14991-branch-2.002.patch
>
>
> This is to backport HDFS-14346 to branch 2, as Standby reads in branch-2 
> requires being able to properly specify ms time granularity for Edit log 
> tailing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to